Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drive): handlers error codes #1394

Merged
merged 28 commits into from
Oct 3, 2023
Merged

feat(drive): handlers error codes #1394

merged 28 commits into from
Oct 3, 2023

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Sep 14, 2023 •
edited
Loading

Issue being fixed or feature implemented

Introduced NotFound, InvalidArgument and Internal ABCI response errors

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io changed the title Feat/drive/grpc error codes feat(drive): drive error codes Sep 14, 2023
@markin-io markin-io changed the title feat(drive): drive error codes feat(drive): handlers error codes Sep 14, 2023
shumkov
shumkov requested changes Sep 19, 2023
View reviewed changes
packages/rs-drive-abci/src/error/handlers.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/query/v0/mod.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/query/v0/mod.rs Outdated Show resolved Hide resolved
shumkov
shumkov requested changes Sep 22, 2023
View reviewed changes
packages/rs-drive-abci/src/abci/handlers.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/abci/handlers.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/abci/handlers.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/query/v0/mod.rs Outdated Show resolved Hide resolved
shumkov
shumkov previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io closed this Oct 2, 2023
@markin-io markin-io deleted the feat/drive/grpc-error-codes branch October 2, 2023 13:55
@markin-io markin-io restored the feat/drive/grpc-error-codes branch October 2, 2023 13:55
@markin-io markin-io reopened this Oct 3, 2023
@shumkov shumkov merged commit f32d415 into v0.25-dev Oct 3, 2023
32 of 56 checks passed
@shumkov shumkov deleted the feat/drive/grpc-error-codes branch October 3, 2023 11:46
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lklimek lklimek lklimek left review comments

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer QuantumExplorer left review comments

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markin-io @shumkov @lklimek @QuantumExplorer @thephez