-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashmate)!: drive logs configuration #1406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
changed the title
Fix/dashmate/drive log
fix(dashmate): drive logs configuration
Sep 18, 2023
shumkov
changed the title
fix(dashmate): drive logs configuration
fix(dashmate)!: drive logs configuration
Sep 19, 2023
lklimek
reviewed
Sep 19, 2023
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
lklimek
reviewed
Sep 19, 2023
lklimek
previously approved these changes
Sep 20, 2023
lklimek
previously approved these changes
Sep 20, 2023
# Conflicts: # packages/dashmate/configs/getConfigFileMigrationsFactory.js
lklimek
reviewed
Oct 3, 2023
lklimek
previously approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
After switching JS Drive to RS Drive the ABCI log file configuration has not been working in dashmate.
What was done?
How Has This Been Tested?
Manually
Breaking Changes
Drive volume is changed so volumes and containers must be recreated. It means platform file must be wiped.
Checklist:
For repository code-owners and collaborators only