Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate)!: drive logs configuration #1406

Merged
merged 28 commits into from
Oct 6, 2023
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Sep 18, 2023

Issue being fixed or feature implemented

After switching JS Drive to RS Drive the ABCI log file configuration has not been working in dashmate.

What was done?

  • Update RS Drive ABCI log configuration:
    • File path instead of dir path
    • String preset for verbosity levels instead of number
    • CLI verbosity flag changed to 3 items max
    • Define only one default logger (stdout)
    • Hide logs for tests by default
    • Small refactoring
    • Added tests for log rotation
  • Set correct paths to Drive ABCI logs for local network

How Has This Been Tested?

Manually

Breaking Changes

Drive volume is changed so volumes and containers must be recreated. It means platform file must be wiped.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title Fix/dashmate/drive log fix(dashmate): drive logs configuration Sep 18, 2023
@shumkov shumkov marked this pull request as ready for review September 19, 2023 10:29
@shumkov shumkov changed the title fix(dashmate): drive logs configuration fix(dashmate)!: drive logs configuration Sep 19, 2023
packages/dashmate/docker-compose.yml Show resolved Hide resolved
packages/rs-drive-abci/src/logging.rs Show resolved Hide resolved
packages/rs-drive-abci/src/logging.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/logging.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/logging.rs Show resolved Hide resolved
packages/rs-drive-abci/src/logging.rs Outdated Show resolved Hide resolved
shumkov and others added 4 commits September 19, 2023 14:21
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
packages/rs-drive-abci/src/logging.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/logging.rs Outdated Show resolved Hide resolved
lklimek
lklimek previously approved these changes Sep 20, 2023
lklimek
lklimek previously approved these changes Sep 20, 2023
# Conflicts:
#	packages/dashmate/configs/getConfigFileMigrationsFactory.js
lklimek
lklimek previously approved these changes Oct 3, 2023
@shumkov shumkov changed the base branch from v0.25-dev to v1.0-dev October 6, 2023 04:05
@shumkov shumkov dismissed lklimek’s stale review October 6, 2023 04:05

The base branch was changed.

@shumkov shumkov merged commit 06518b8 into v1.0-dev Oct 6, 2023
17 checks passed
@shumkov shumkov deleted the fix/dashmate/drive-log branch October 6, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants