Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make self-hosted actions-cache steps access S3 from correct region #1407

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Sep 18, 2023

Issue being fixed or feature implemented

#1398 reverted #1391 without resolving the original issue

What was done?

Add a condition the AWS login step so it only occurs on AWS self-hosted runner infra

How Has This Been Tested?

In CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

.github/actions/nodejs/action.yaml Outdated Show resolved Hide resolved
.github/actions/rust/action.yaml Outdated Show resolved Hide resolved
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 62b9562 into v0.25-dev Sep 20, 2023
8 checks passed
@shumkov shumkov deleted the ci/conditional-aws-login branch September 20, 2023 12:57
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants