Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashmate): platform reset failure #1415

Merged
merged 2 commits into from
Sep 21, 2023
Merged

fix(dashmate): platform reset failure #1415

merged 2 commits into from
Sep 21, 2023

Conversation

pshenmic
Copy link
Collaborator

Issue being fixed or feature implemented

#1414

Reset command with platform only flag is broken

What was done?

  • Pass profiles to to the isNodeRunning

How Has This Been Tested?

Locally on my macbook

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic self-assigned this Sep 20, 2023
strophy
strophy approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@strophy strophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shumkov shumkov changed the title fix(dashmate): pass platform profiles for flag fix(dashmate): platform reset fails Sep 20, 2023
@shumkov shumkov changed the title fix(dashmate): platform reset fails fix(dashmate): platform reset failure Sep 20, 2023
@pshenmic pshenmic merged commit e730f62 into v0.25-dev Sep 21, 2023
10 checks passed
@pshenmic pshenmic deleted the fix/dashmate-reset-platform branch September 21, 2023 04:04
@pshenmic pshenmic mentioned this pull request Sep 25, 2023
Closed
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strophy strophy strophy approved these changes

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees

@pshenmic pshenmic

Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pshenmic @shumkov @strophy @thephez