fix(dapi): getTransaction google-protobuf AssertionError #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markin-io
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
shumkov
requested changes
Sep 20, 2023
packages/dapi/lib/grpcServer/handlers/core/getTransactionHandlerFactory.js
Show resolved
Hide resolved
packages/dapi/lib/grpcServer/handlers/core/getTransactionHandlerFactory.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Fixes bug with serializing of
GetTransactionResponsefor DAPIgetTransactionhandlerWhat was done?
Implemented uint32 validation for fields
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only