Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add logger to dapi client #1420

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Conversation

markin-io
Copy link
Contributor

Issue being fixed or feature implemented

Adds logger to DAPI client to log requests and nodes they went to

What was done?

Log requests going through GrpcTransport and JsonRPCTransport

How Has This Been Tested?

Sample output

debug: [DAPIClient: e9b4204b5d] GRPC Request getIdentity to https://127.0.0.1:2443 { options: { retries: 5, timeout: 25000 }}

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io added this to the v0.25.0 milestone Sep 22, 2023
@markin-io markin-io changed the title feat(dapi-client): add logger feat(sdk): add logger to dapi client Sep 22, 2023
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io merged commit a9bb55c into v0.25-dev Oct 4, 2023
20 checks passed
@markin-io markin-io deleted the feat/dapi-client-logging branch October 4, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants