fix(drive)!: non-deterministic extended quorum info #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
changed the title
markin-io
previously approved these changes
Sep 27, 2023
QuantumExplorer
dismissed stale reviews from markin-io and themself
via
45d3be5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Drive ABCI stores the extended quorum info obtained from Core via RPC. Dashcore RPC is using
HashMapso the quorum extended info structured non-deterministically. In result, we might have different AppHash for the same block height.What was done?
BTreeMapHow Has This Been Tested?
None
Breaking Changes
Drive ABCI state is changed. Previous blockchain data is incompatible
Checklist:
For repository code-owners and collaborators only