Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drive): drive-abci verify grovedb CLI #1427

Merged
merged 5 commits into from
Sep 28, 2023
Merged

feat(drive): drive-abci verify grovedb CLI #1427

merged 5 commits into from
Sep 28, 2023

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Sep 27, 2023 •
edited
Loading

Issue being fixed or feature implemented

MNOs and infra teams need a way to verify grovedb hash integrity.

What was done?

Added drive-abci verify command and respective docs.

How Has This Been Tested?

  • locally, calling cargo run -p drive-abci -- -c packages/rs-drive-abci/.env verify
  • in dashmate-created local devnet, following the docs

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review September 28, 2023 06:48
QuantumExplorer
QuantumExplorer approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work

@QuantumExplorer QuantumExplorer merged commit 4ac022b into v0.25-dev Sep 28, 2023
15 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/verify-grovedb-cli branch September 28, 2023 15:45
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov Awaiting requested review from shumkov

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lklimek @QuantumExplorer @thephez