Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drive): add grpc error codes to handlers #1447

Closed
wants to merge 28 commits into from
Closed

feat(drive): add grpc error codes to handlers #1447

wants to merge 28 commits into from

Conversation

markin-io
Copy link
Contributor

Issue being fixed or feature implemented

Introduced NotFound, InvalidArgument and Internal ABCI response errors

What was done?

  • Added grpc error codes to the response
  • Added to_cbor_buffer to platform_value

How Has This Been Tested?

  • CI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov and others added 26 commits September 8, 2023 12:24
@shumkov
fix(drive): -32603 error code on broadcast
df500e4
@shumkov
fix: wrong cbor macros syntax
4548545
@shumkov
fix: wrong error data encoded
0d72be2
@shumkov
fix: json error from tenderdash code passed as an actual code in meta…
db84706 
…data
@markin-io
feat(rs-platform-value): to_cbor_buffer on Value
bb525d7
@markin-io
refactor(drive-abci): response errors
3bc2f74
@markin-io
feat: internal error
c0a34cb
@markin-io
feat: not found error
1c8202c
@markin-io
feat: invalid argument error
ca5e06f
@markin-io
Merge branch 'v0.25-dev' into feat/drive/grpc-error-codes
5a769f6
@markin-io
test(dapi): fix
5256a21
@markin-io
refactor(dapi): remove commented code
e541dba
@markin-io
fix comments
3180b4f
@markin-io
feat(drive): return all error codes
3bc1b6c
@markin-io
refactor(drive): rename Query error to DocumentQuery
8b7eb87
@markin-io
Merge branch 'v0.25-dev' into feat/drive/grpc-error-codes
7b15814
@shumkov
refactor: remove info encoding duplication
1bdf494
@markin-io
fix(drive): get rid of redundant handler error prefix
ddb0aa9
@markin-io
Merge branch 'feat/drive/grpc-error-codes' of github.com:dashpay/plat…
141468e 
…form into feat/drive/grpc-error-codes
@markin-io
Revert "refactor(drive): rename Query error to DocumentQuery"
b4e5685 
This reverts commit 8b7eb87.
@markin-io
fix(drive): documentation
75fac6d
@markin-io
fix(drive): get rid of unnecessary proof length check
72bf115
@QuantumExplorer
Merge branch 'v0.25-dev' into feat/drive/grpc-error-codes
9377fa0
@markin-io
Merge branch 'v0.25-dev' into feat/drive/grpc-error-codes
9e494b9
@markin-io
build: cargo.lock update
6c5a2ce
@shumkov
Merge branch 'v0.25-dev' into feat/drive/grpc-error-codes
97dfb56
@markin-io markin-io added this to the v0.25.0 milestone Oct 2, 2023
@markin-io markin-io closed this Oct 3, 2023
@shumkov shumkov deleted the feat/drive/grpc-error-codes branch October 3, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov Awaiting requested review from shumkov

@antouhou antouhou Awaiting requested review from antouhou

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markin-io @shumkov @QuantumExplorer