-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: mitigate homograph attack in DPNS #1454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
requested changes
Oct 5, 2023
...ion/state_transition/state_transitions/documents_batch/data_triggers/triggers/dpns/v0/mod.rs
Show resolved
Hide resolved
...ion/state_transition/state_transitions/documents_batch/data_triggers/triggers/dpns/v0/mod.rs
Outdated
Show resolved
Hide resolved
QuantumExplorer
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
With DPNS you can register very similar domain names that malicious actors could use in DashPay to mimic others and receive their transactions.
What was done?
parentDomainName
property so we can restore the origin full domain name concatenatinglabel
+.
parentDomainName
.How Has This Been Tested?
Unit tests and the test suite are updated.
Breaking Changes
The DPNS system data contract is changed so the previously created state won't be valid.
Checklist:
For repository code-owners and collaborators only