Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: mitigate homograph attack in DPNS #1454

Merged
merged 14 commits into from
Oct 6, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Oct 5, 2023

Issue being fixed or feature implemented

With DPNS you can register very similar domain names that malicious actors could use in DashPay to mimic others and receive their transactions.

What was done?

  • Convert normalized label and parent domain name to base58 chars so you can't register both "HOST" and "H0ST" names.
  • Added parentDomainName property so we can restore the origin full domain name concatenating label + . parentDomainName.

How Has This Been Tested?

Unit tests and the test suite are updated.

Breaking Changes

The DPNS system data contract is changed so the previously created state won't be valid.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v0.25-dev to v1.0-dev October 5, 2023 15:56
@shumkov shumkov added this to the v1.0.0 milestone Oct 5, 2023
@shumkov shumkov merged commit 7862e84 into v1.0-dev Oct 6, 2023
42 of 43 checks passed
@shumkov shumkov deleted the feat/dpns/mitigate-homograph-attack branch October 6, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants