Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drive)!: document type doesn't match array value #1457

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Oct 7, 2023

Issue being fixed or feature implemented

ERROR drive_abci::abci::handlers: check_tx failed, error: Drive(Protocol(DataContractError(ValueWrongType("document field type doesn't match document value for array"))))

It happens when we create a document for data contract that contain an array of arrays property which is not supported at moment.

What was done?

  • Do not allow to define any array types except byte arrays
  • Removed some unused schemas

How Has This Been Tested?

Manual testing

Breaking Changes

Contracts with arrays won't be valid anymore

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v0.25-dev to v1.0-dev October 7, 2023 01:28
@shumkov shumkov added this to the v1.0.0 milestone Oct 7, 2023
@shumkov shumkov merged commit dbf618c into v1.0-dev Oct 9, 2023
23 of 25 checks passed
@shumkov shumkov deleted the fix/drive/document-type-array branch October 9, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants