chore: increase scopes for ci #1460
Conversation
| @@ -33,14 +33,17 @@ jobs: | |||
| # These are regex patterns auto-wrapped in `^ $`. | |||
| scopes: | | |||
| dapi | |||
| platform | |||
There was a problem hiding this comment.
If it's platform (all or multiple packages) you just doesn't specify the scope.
There was a problem hiding this comment.
Well I see Drive+Drive-ABCI+DPP to be Platform, and very different from dashmate for example, often those 3 will be updated together. So I think it's a good thing to add and makes things more readable.
There was a problem hiding this comment.
Conceptually all packages in this repo are parts of the platform. Platform test suite, SDK, and DAPI...
"Drive+Drive-ABCI+DPP" for this we had a more general "drive", basically a blockchain runtime.
There was a problem hiding this comment.
Well that's just because of the history of teams that worked on the project a long time ago, Drive should be drive, not execution logic.
.github/workflows/pr.yml
Outdated
| dpp | ||
| dashmate | ||
| contract | ||
| sdk | ||
| wallet-lib | ||
| test-suite | ||
| bench-suite | ||
| ci |
There was a problem hiding this comment.
There is a commit type "ci" already included with conventional commits. e.g "ci: made life better"
Issue being fixed or feature implemented
Not all scopes were present in CI PR title check
What was done?
Added Drive-Abci, Platform and CI scopes.
When to use them:
Drive-Abci: when the fix is only in Drive-Abci we should use that as a tag. Drive now would refer to the storage crate.
Platform: often when dealing with complex features or fixes, we need to make major modifications in dpp, drive and drive-abci. In this case we should set the scope Platform.
CI: If we are just changing actions or CI, the scope should be CI.
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only