Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve various warnings during build or by clippy #1761

Merged
merged 14 commits into from
Mar 10, 2024

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Resolve build warnings

What was done?

Resolve build warnings

cargo check --tests now returns only 1 warning; which according to @QuantumExplorer should be resolved in future?

> $ cargo check --tests                                                                                                                                                                                                       [±wip/refac/clippy ●]
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/pasta/workspace/platform/packages/wasm-dpp/Cargo.toml
workspace: /Users/pasta/workspace/platform/Cargo.toml
warning: /Users/pasta/workspace/platform/packages/rs-drive-proof-verifier/Cargo.toml: unused manifest key: package.crate-type
warning: skipping duplicate package `embedded` found at `/Users/pasta/.cargo/git/checkouts/rust-dashcore-b01a88e2cb0da4a0/25053c8/dash/embedded`
warning: use of deprecated method `tenderdash_abci::signatures::Signable::sign_digest`: replaced by calculate_sign_hash() to unify naming between core, platform and tenderdash
  --> packages/rs-drive-proof-verifier/src/verify.rs:78:10
   |
78 |         .sign_digest(
   |          ^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: `drive-proof-verifier` (lib) generated 1 warning
warning: `drive-proof-verifier` (lib test) generated 1 warning (1 duplicate)
    Finished dev [unoptimized + debuginfo] target(s) in 0.76s

How Has This Been Tested?

cargo t in root

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit e831503 into v1.0-dev Mar 10, 2024
77 checks passed
@QuantumExplorer QuantumExplorer deleted the refac/resolve-warnings branch March 10, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants