-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk)!: don't allow duplicate mock expectations #1788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1f249d
to
4ae111d
Compare
…sdk test Config::setup_api()
…d in rs-sdk test Config::setup_api()" This reverts commit 0e631bf.
QuantumExplorer
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Right now, when adding new expected request/response pair to rs-sdk / rs-dapi-client with the duplicate request, previous request is silently replaced. This can cause non-deterministic behavior, where test result depends on order in which expectations are added.
What was done?
Return error when duplicate expectation is created.
Separate test vectors from various tests into separate directories (
namespaces
) to avoid conflicts.How Has This Been Tested?
Added unit tests.
Commented out code that deletes old test vectors. Then, called the following command 3 times, to generate conflicting test vectors:
Then started
cargo test -p rs-sdk document_read
to ensure it fails withMockExpectationConflict
errors.Breaking Changes
Checklist:
For repository code-owners and collaborators only