feat(strategy-tests): add extra_keys field for StartIdentities and use random identities for transfers #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
requested changes
Mar 24, 2024
packages/strategy-tests/src/lib.rs
Outdated
Comment on lines
1333
to
1346
| // Make sure we insert a key for transfers | ||
| let mut key_maps: KeyMaps = [( | ||
| Purpose::TRANSFER, | ||
| [(SecurityLevel::CRITICAL, vec![KeyType::ECDSA_SECP256K1])].into(), | ||
| )] | ||
| .into(); | ||
| let mut new_key_count = self.start_identities.keys_per_identity - 1; | ||
|
|
||
| // Also an authentication key with critical security level for documents | ||
| key_maps.insert( | ||
| Purpose::AUTHENTICATION, | ||
| [(SecurityLevel::CRITICAL, vec![KeyType::ECDSA_SECP256K1])].into(), | ||
| ); | ||
| new_key_count -= 1; |
There was a problem hiding this comment.
I on purpose didn't want to add the transfer key to all identities.
There was a problem hiding this comment.
Fixed. I added extra_keys field for StartIdentities struct and the users can select whether or not to add a transfer key in the TUI
packages/strategy-tests/src/lib.rs
Outdated
Comment on lines
421
to
423
| for identity in &identities { | ||
| identity_nonce_counter.insert(identity.id(), 1); | ||
| } |
There was a problem hiding this comment.
I think this means we would start things at 2.
There was a problem hiding this comment.
Fixed (removed it because it wasn't necessary)
pauldelucia
changed the title
pauldelucia
changed the title
pauldelucia
changed the title
QuantumExplorer
requested changes
Mar 28, 2024
packages/strategy-tests/src/lib.rs
Outdated
| } | ||
|
|
||
| // Select a random identity from the current_identities for the sender | ||
| let random_index_sender = thread_rng().gen_range(0..identities_count); |
There was a problem hiding this comment.
don't you want to use rng, so that tests are determinisitic based on the seed?
There was a problem hiding this comment.
Fixed. Changed to rng
QuantumExplorer
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We might want Strategy StartIdentities to have transfer keys or other extra keys in addition to the main keys. Also, there was an issue with public key IDs in
transitions.rs.What was done?
We add an extra_keys field similar to that in IdentityInserts and fix the issue in
transitions.rs.How Has This Been Tested?
Platform TUI strategy tests
Breaking Changes
Checklist:
For repository code-owners and collaborators only