Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(platform)!: disable credit withdrawals in V1 #1961

Merged
merged 5 commits into from
Jul 16, 2024
Merged

chore(platform)!: disable credit withdrawals in V1 #1961

merged 5 commits into from
Jul 16, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

Platform hasn't been tested enough for withdrawals, hence we and the network with a vote decided to go an accelerated release that would see withdrawals disabled for the first version.

What was done?

Disabled withdrawals.

How Has This Been Tested?

Unit test

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner July 16, 2024 08:05
shumkov
shumkov approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title feat(platform)!: disable credit withdrawals in V1 chore(platform)!: disable credit withdrawals in V1 Jul 16, 2024
ogabrielides
ogabrielides approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuantumExplorer QuantumExplorer merged commit 1739623 into v1.0-dev Jul 16, 2024
64 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/disableWithdrawals branch July 16, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@ogabrielides ogabrielides ogabrielides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuantumExplorer @shumkov @ogabrielides