Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): update changelog and version to 1.4.1 #2239

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Oct 12, 2024

Issue being fixed or feature implemented

Release new Dash Platform version

What was done?

  • Updated changelog
  • Bumped packages version

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

Release Notes for Version 1.4.1

  • Breaking Changes

    • Enhanced asynchronous processing in the SDK's mock context provider.
    • Adjustments to owner keys, withdrawal fees, and automatic retries for withdrawals.
  • Bug Fixes

    • Resolved issue with testnet chain synchronization.
  • Miscellaneous Chores

    • Added extra unit tests and improved code comments.
  • Documentation

    • Updated documentation to reflect the latest changes.
  • Version Updates

    • Incremented version numbers across multiple packages to 1.4.1.

Copy link
Contributor

coderabbitai bot commented Oct 12, 2024

Walkthrough

This pull request introduces version 1.4.1 for the Dashpay platform, updating the CHANGELOG.md to reflect various categories of changes, including breaking changes, bug fixes, and improvements in tests and documentation. Additionally, multiple package.json and Cargo.toml files across various packages have been incremented to version 1.4.1, indicating a coordinated update across the platform's components.

Changes

File Path Change Summary
CHANGELOG.md Added section for version 1.4.1 detailing changes: breaking changes, bug fixes, chores, refactoring, CI updates, tests, and documentation.
package.json Updated version from 1.4.0 to 1.4.1.
packages/bench-suite/package.json Updated version from 1.4.0 to 1.4.1.
packages/check-features/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/dapi-grpc/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/dapi-grpc/package.json Updated version from 1.4.0 to 1.4.1.
packages/dapi/package.json Updated version from 1.4.0 to 1.4.1.
packages/dash-spv/package.json Updated version from 2.4.0 to 2.4.1.
packages/dashmate/package.json Updated version from 1.4.0 to 1.4.1.
packages/dashpay-contract/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/dashpay-contract/package.json Updated version from 1.4.0 to 1.4.1.
packages/data-contracts/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/dpns-contract/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/dpns-contract/package.json Updated version from 1.4.0 to 1.4.1.
packages/feature-flags-contract/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/feature-flags-contract/package.json Updated version from 1.4.0 to 1.4.1.
packages/js-dapi-client/package.json Updated version from 1.4.0 to 1.4.1.
packages/js-dash-sdk/package.json Updated version from 4.4.0 to 4.4.1.
packages/js-grpc-common/package.json Updated version from 1.4.0 to 1.4.1.
packages/masternode-reward-shares-contract/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/masternode-reward-shares-contract/package.json Updated version from 1.4.0 to 1.4.1.
packages/platform-test-suite/package.json Updated version from 1.4.0 to 1.4.1.
packages/rs-dapi-client/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-dapi-grpc-macros/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-dpp/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-drive-abci/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-drive-proof-verifier/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-drive/Cargo.toml Updated version from 1.4.0 to 1.4.1; corrected author email format.
packages/rs-json-schema-compatibility-validator/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-platform-serialization-derive/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-platform-serialization/Cargo.toml Updated version from 1.4.0 to 1.4.1; updated bincode dependency to 2.0.0-rc.3.
packages/rs-platform-value-convertible/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-platform-value/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-platform-version/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-platform-versioning/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/rs-sdk/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/simple-signer/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/strategy-tests/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/wallet-lib/package.json Updated version from 8.4.0 to 8.4.1.
packages/wasm-dpp/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/wasm-dpp/package.json Updated version from 1.4.0 to 1.4.1.
packages/withdrawals-contract/Cargo.toml Updated version from 1.4.0 to 1.4.1.
packages/withdrawals-contract/package.json Updated version from 1.4.0 to 1.4.1.

Possibly related PRs

Suggested reviewers

  • QuantumExplorer

🐇 "In the garden, we hop with glee,
Version 1.4.1 is here, you see!
With fixes and features, all in a row,
Dashpay's bright future is set to glow!
So let’s celebrate with a joyful cheer,
For every little change brings us near!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shumkov shumkov added this to the 1.4.1 milestone Oct 12, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (5)
CHANGELOG.md (5)

1-21: Version 1.4.1 changes look good, but consider adding more details

The changelog entry for version 1.4.1 provides a good overview of the changes. However, it could benefit from more detailed explanations, especially for the breaking changes and bug fixes. Consider expanding on the following points:

  1. For the breaking change in the SDK, explain what "improve mock context provider async processing" means and how it might affect users.
  2. For the bug fix "testnet chain sync failed", provide more context on what caused the issue and how it was resolved.
  3. For the miscellaneous chores and code refactoring, give a brief explanation of why these changes were made and their potential impact.

Adding more details will help users understand the significance of these changes and how they might affect their projects.


Line range hint 23-103: Version 1.4.0 includes significant updates and breaking changes

The changelog for version 1.4.0 is comprehensive and includes many important updates. Here are some key points to note:

  1. There are several breaking changes, including modifications to identities, withdrawal fees, and SDK default network settings. These changes are well-documented and should be highlighted to users.

  2. The feature list is extensive, covering improvements to various components such as DPP, SDK, Platform, and Dashmate. This demonstrates significant progress across the platform.

  3. The bug fixes address a wide range of issues, which is positive for platform stability.

  4. The documentation updates, build system changes, and continuous integration improvements show a commitment to maintaining and improving the development process.

Overall, this is a substantial update with clear explanations for most changes. However, consider adding brief explanations for some of the more technical changes to help users understand their impact.

Consider adding brief explanations for some of the more technical changes, especially in the features and bug fixes sections, to help users understand their significance and potential impact on their projects.


Line range hint 105-426: Development versions provide good insight into the evolution of 1.4.0

The changelog entries for versions 1.4.0-dev.8 to 1.4.0-dev.1 provide a detailed look at the development process leading up to the 1.4.0 release. Here are some observations:

  1. The development versions show a gradual introduction of features and fixes that are reflected in the final 1.4.0 release.

  2. Breaking changes are consistently noted throughout the development process, which is good for transparency.

  3. The changelogs for these development versions provide more detailed explanations for some changes compared to the final 1.4.0 release notes.

  4. There's a clear progression of improvements across various components of the platform.

Overall, these development version changelogs are informative and well-maintained. They provide valuable context for the changes that made it into the final 1.4.0 release.

Consider incorporating some of the more detailed explanations from the development version changelogs into the final 1.4.0 release notes, especially for significant features or breaking changes. This would provide users with more context and understanding of the changes.


Line range hint 428-2029: Versions 0.25.x and 0.24.x show significant platform evolution

The changelog entries for versions 0.25.x and 0.24.x demonstrate substantial development and improvement of the Dash Platform. Key observations:

  1. Both versions introduced numerous breaking changes, indicating significant evolution of the platform's architecture and APIs.

  2. There's a consistent focus on improving core functionalities, such as identity management, data contracts, and state transitions.

  3. Performance improvements and optimizations are frequently mentioned, showing a commitment to platform efficiency.

  4. Security enhancements and bug fixes are prevalent throughout these versions.

  5. There's ongoing work on developer tools and documentation, improving the platform's usability for developers.

  6. Continuous integration and build system improvements are regularly mentioned, indicating a focus on maintaining a robust development process.

These versions represent a period of rapid development and refinement of the Dash Platform, with a clear focus on stability, performance, and developer experience.

Consider adding a high-level summary at the beginning of each major version (0.25.0 and 0.24.0) to highlight the most significant changes and the overall focus of that version. This would help users quickly understand the major developments without having to read through all the detailed changes.


Line range hint 2031-2048: Changelog structure and historical information are helpful

The inclusion of information about versions prior to 0.21.x and links to individual package changelogs is valuable:

  1. It provides context for the project's history and evolution.
  2. The links to individual package changelogs are helpful for users who need more detailed historical information.
  3. This section clearly marks the transition point where the project structure changed significantly.

The overall structure of the changelog is effective:

  1. It follows a chronological order, with the most recent versions at the top.
  2. Each version clearly lists features, bug fixes, and other types of changes.
  3. Breaking changes are consistently highlighted, which is crucial for users updating their projects.

Consider adding a brief explanation at the top of the changelog about its structure and how to navigate it. This could include information about the versioning scheme, the meaning of different change types (e.g., Features, Bug Fixes, BREAKING CHANGES), and how to use the links to previous package changelogs.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b6bb2b5 and e34ef42.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (43)
  • CHANGELOG.md (1 hunks)
  • package.json (1 hunks)
  • packages/bench-suite/package.json (1 hunks)
  • packages/check-features/Cargo.toml (1 hunks)
  • packages/dapi-grpc/Cargo.toml (1 hunks)
  • packages/dapi-grpc/package.json (1 hunks)
  • packages/dapi/package.json (1 hunks)
  • packages/dash-spv/package.json (1 hunks)
  • packages/dashmate/package.json (1 hunks)
  • packages/dashpay-contract/Cargo.toml (1 hunks)
  • packages/dashpay-contract/package.json (1 hunks)
  • packages/data-contracts/Cargo.toml (1 hunks)
  • packages/dpns-contract/Cargo.toml (1 hunks)
  • packages/dpns-contract/package.json (1 hunks)
  • packages/feature-flags-contract/Cargo.toml (1 hunks)
  • packages/feature-flags-contract/package.json (1 hunks)
  • packages/js-dapi-client/package.json (1 hunks)
  • packages/js-dash-sdk/package.json (1 hunks)
  • packages/js-grpc-common/package.json (1 hunks)
  • packages/masternode-reward-shares-contract/Cargo.toml (1 hunks)
  • packages/masternode-reward-shares-contract/package.json (1 hunks)
  • packages/platform-test-suite/package.json (1 hunks)
  • packages/rs-dapi-client/Cargo.toml (1 hunks)
  • packages/rs-dapi-grpc-macros/Cargo.toml (1 hunks)
  • packages/rs-dpp/Cargo.toml (1 hunks)
  • packages/rs-drive-abci/Cargo.toml (1 hunks)
  • packages/rs-drive-proof-verifier/Cargo.toml (1 hunks)
  • packages/rs-drive/Cargo.toml (1 hunks)
  • packages/rs-json-schema-compatibility-validator/Cargo.toml (1 hunks)
  • packages/rs-platform-serialization-derive/Cargo.toml (1 hunks)
  • packages/rs-platform-serialization/Cargo.toml (1 hunks)
  • packages/rs-platform-value-convertible/Cargo.toml (1 hunks)
  • packages/rs-platform-value/Cargo.toml (1 hunks)
  • packages/rs-platform-version/Cargo.toml (1 hunks)
  • packages/rs-platform-versioning/Cargo.toml (1 hunks)
  • packages/rs-sdk/Cargo.toml (1 hunks)
  • packages/simple-signer/Cargo.toml (1 hunks)
  • packages/strategy-tests/Cargo.toml (1 hunks)
  • packages/wallet-lib/package.json (1 hunks)
  • packages/wasm-dpp/Cargo.toml (1 hunks)
  • packages/wasm-dpp/package.json (1 hunks)
  • packages/withdrawals-contract/Cargo.toml (1 hunks)
  • packages/withdrawals-contract/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (41)
  • package.json
  • packages/bench-suite/package.json
  • packages/check-features/Cargo.toml
  • packages/dapi-grpc/Cargo.toml
  • packages/dapi-grpc/package.json
  • packages/dapi/package.json
  • packages/dash-spv/package.json
  • packages/dashmate/package.json
  • packages/dashpay-contract/Cargo.toml
  • packages/dashpay-contract/package.json
  • packages/data-contracts/Cargo.toml
  • packages/dpns-contract/Cargo.toml
  • packages/dpns-contract/package.json
  • packages/feature-flags-contract/Cargo.toml
  • packages/feature-flags-contract/package.json
  • packages/js-dapi-client/package.json
  • packages/js-dash-sdk/package.json
  • packages/js-grpc-common/package.json
  • packages/masternode-reward-shares-contract/Cargo.toml
  • packages/masternode-reward-shares-contract/package.json
  • packages/platform-test-suite/package.json
  • packages/rs-dapi-client/Cargo.toml
  • packages/rs-dapi-grpc-macros/Cargo.toml
  • packages/rs-dpp/Cargo.toml
  • packages/rs-drive-proof-verifier/Cargo.toml
  • packages/rs-drive/Cargo.toml
  • packages/rs-json-schema-compatibility-validator/Cargo.toml
  • packages/rs-platform-serialization-derive/Cargo.toml
  • packages/rs-platform-serialization/Cargo.toml
  • packages/rs-platform-value-convertible/Cargo.toml
  • packages/rs-platform-value/Cargo.toml
  • packages/rs-platform-version/Cargo.toml
  • packages/rs-platform-versioning/Cargo.toml
  • packages/rs-sdk/Cargo.toml
  • packages/simple-signer/Cargo.toml
  • packages/strategy-tests/Cargo.toml
  • packages/wallet-lib/package.json
  • packages/wasm-dpp/Cargo.toml
  • packages/wasm-dpp/package.json
  • packages/withdrawals-contract/Cargo.toml
  • packages/withdrawals-contract/package.json
🧰 Additional context used
🔇 Additional comments (2)
packages/rs-drive-abci/Cargo.toml (2)

3-3: Version update looks good.

The package version has been correctly updated to 1.4.1, which aligns with the PR objective of releasing a new minor version.


1-1: Dev-dependencies update looks good, but needs clarification.

The additional features added to the dpp dependency in the [dev-dependencies] section appear to be beneficial for testing and development. However, these changes were not mentioned in the PR description or objectives.

Could you please clarify the reason for adding these new features to the dev-dependencies? This will help ensure that the changes align with the intended scope of this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants