revert: do not run test on push

[shumkov]

Reverts #2308

Summary by CodeRabbit

• Chores
  • Updated workflow configuration to include additional triggers for better automation.
  • Introduced a daily scheduled job to enhance workflow flexibility.

[coderabbitai]

Walkthrough

The changes in the pull request involve updates to the GitHub Actions workflow configuration in .github/workflows/tests.yml. The workflow now includes a push event trigger for the master branch and branches matching the pattern 'v[0-9]+\.[0-9]+-dev'. Additionally, a scheduled job has been introduced, set to run daily at 4:30 AM UTC. Several jobs have been modified to execute on both scheduled runs and specific events, enhancing the workflow's responsiveness to various triggers.

Changes

File	Change Summary
.github/workflows/tests.yml	- Added push triggers for master and 'v[0-9]+\.[0-9]+-dev' branches.
	- Introduced a daily scheduled job at 4:30 AM UTC.
	- Updated if conditions for multiple jobs to include the schedule event.

Possibly related PRs

• ci: do not run test on push #2308: This PR modifies the same .github/workflows/tests.yml file by removing the push trigger, which is directly related to the changes made in the main PR that adds the push trigger.

Suggested reviewers

• QuantumExplorer
• lklimek

Poem

In the morning light, a schedule we make,
Our workflow dances, no time to forsake.
With pushes and triggers, it hops with delight,
Daily at dawn, it’s ready to fight!
So let’s cheer for the changes, both bold and bright! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ff2a831 and a526ceb.

📒 Files selected for processing (1)

• .github/workflows/tests.yml (1 hunks)

🧰 Additional context used

🪛 actionlint

.github/workflows/tests.yml

13-13: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

(glob)

🔇 Additional comments (2)

.github/workflows/tests.yml (2)

10-15: LGTM! Good addition of scheduled runs.

The reversion of push event triggers looks correct, and the addition of scheduled runs at 4:30 AM UTC is a good practice for catching issues that might not be detected during regular development activities.

🧰 Tools

🪛 actionlint

13-13: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

(glob)

---

Line range hint 23-23: Verify job conditions are consistently applied.

The conditions for running jobs on push, workflow_dispatch, schedule events, and non-draft PRs are consistently applied across all relevant jobs. This ensures uniform behavior across the workflow.

Also applies to: 45-45, 52-52, 82-82, 108-108, 127-127

✅ Verification successful

Job conditions are consistently applied across main workflow jobs

The verification confirms that the condition if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || !github.event.pull_request.draft }} is consistently applied across all the primary jobs in the workflow. The only exception is a different condition for a dependent job that uses needs.changes.outputs, which is expected as it serves a different purpose.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistency of job conditions across the workflow

# Check if all jobs have the same condition
rg -A 1 "if: \$\{\{ github\.event_name == 'push' \|\| github\.event_name == 'workflow_dispatch' \|\| github\.event_name == 'schedule' \|\| \!github\.event\.pull_request\.draft \}\}"

Length of output: 566

---

Script:

#!/bin/bash
# Description: Verify consistency of job conditions across the workflow using simpler pattern
# Using simpler pattern to avoid regex escaping issues
rg "if: " .github/workflows/tests.yml -A 1

Length of output: 1221

🧰 Tools

🪛 actionlint

9-9: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

(glob)

---

13-13: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

(glob)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.