fix(dashmate): failing doctor with drive metrics enabled

[shumkov]

Issue being fixed or feature implemented

ubuntu@~$ dashmate doctor
❯ Collecting samples
  ✔ System information
  ✔ Configuration
    ✔ Gateway SSL certificates
    ✔ Core P2P port
    ✔ Gateway HTTP port
    ✔ Tenderdash P2P port
  ✔ Core status
  ✔ Tenderdash status
  ✖ There is no option with 'platform.drive.abci.rpc.host' path
  ◼ Docker containers info
◼ Analyzing samples

What was done?

• Fixed invalid config path to platform.drive.abci.metrics.host

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes

  • Updated the URL construction for fetching metrics related to the ABCI service to ensure accurate data retrieval.

• Chores

  • Maintained existing functionality and error handling in the collectSamplesTask without introducing new logic.

[coderabbitai]

Walkthrough

The changes in this pull request focus on modifying the URL construction within the collectSamplesTaskFactory function in the collectSamplesTaskFactory.js file. The update shifts the source of the metrics URL from platform.drive.abci.rpc.host and platform.drive.abci.rpc.port to platform.drive.abci.metrics.host and platform.drive.abci.metrics.port. This adjustment does not alter the overall structure or functionality of the collectSamplesTask function, as existing error handling and control flow remain unchanged.

Changes

File Path	Change Summary
packages/dashmate/src/listr/tasks/doctor/collectSamplesTaskFactory.js	Updated metrics URL construction to use platform.drive.abci.metrics.host and platform.drive.abci.metrics.port. No changes to task definitions or error handling.

Possibly related PRs

• chore(dashmate): report port check errors #2245: This PR modifies the collectSamplesTaskFactory function in the same file as the main PR, enhancing error handling for port check responses.
• fix(dashmate): invalid drive status check #2248: This PR includes changes to the StatusCommand class and introduces a new environment variable related to metrics, connecting to the URL construction changes in the main PR.
• fix(dashmate): invalid platform version in the status command #2249: This PR modifies the StatusCommand class and the logic for platform version retrieval, which may relate to the metrics URL changes in the main PR.

Suggested labels

dashmate

Suggested reviewers

• QuantumExplorer
• pshenmic

Poem

🐰 In the code where metrics play,
A rabbit hops to change the way.
From RPC to metrics, we now fetch,
With a new URL, we make the switch!
Hopping along, the tasks remain,
Fetching info, like sunshine after rain! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between dd54205 and e25e0e2.

📒 Files selected for processing (1)

• packages/dashmate/src/listr/tasks/doctor/collectSamplesTaskFactory.js (1 hunks)

🔇 Additional comments (1)

packages/dashmate/src/listr/tasks/doctor/collectSamplesTaskFactory.js (1)

299-299: LGTM! Configuration path correction looks good.

The change from rpc.host/port to metrics.host/port for Drive metrics:

1. Fixes the failing doctor command
2. Aligns with the metrics configuration pattern used by other services
3. Maintains consistent error handling via fetchTextOrError

Let's verify the configuration paths across the codebase:

✅ Verification successful

The search results show that:

1. The new metrics.host/port configuration path is used consistently in collectSamplesTaskFactory.js
2. The same configuration path is also used in setupLocalPresetTaskFactory.js for port configuration
3. There are no occurrences of the old rpc.host/port pattern

Let's verify the default configuration to ensure it's properly defined:

---

Based on the search results, I can now verify that:

1. The metrics.host/port configuration path is used correctly in collectSamplesTaskFactory.js
2. The configuration is properly defined in the base config and migrations
3. The change aligns with the platform's configuration structure where metrics endpoints are consistently configured under their respective components

Let me verify one final aspect - the metrics configuration in the default configs:

---

Based on the comprehensive verification results, I can now provide a final response:

The change from rpc.host/port to metrics.host/port is correct and properly aligned with the codebase

The verification confirms:

1. The metrics configuration path platform.drive.abci.metrics is properly defined in the base config
2. The metrics configuration follows the same pattern used by other services (Tenderdash, Gateway)
3. The change is part of a proper migration path in the config migrations
4. No other references to the old rpc.host/port pattern for Drive metrics exist

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the metrics configuration paths usage across the codebase

# Search for metrics configuration patterns
echo "Checking metrics configuration patterns..."
rg -A 2 "platform\.drive\.abci\.(metrics|rpc)\.(host|port)"

# Search for doctor command related files
echo "Checking doctor command related files..."
fd -e js -e json doctor

Length of output: 1288

---

Script:

#!/bin/bash
# Check default configuration files for Drive metrics settings
echo "Checking default configurations..."
fd -e json -e js config --exec grep -l "drive.abci" {} \; | xargs cat

# Check schema definitions
echo "Checking schema definitions..."
fd -e json schema --exec grep -l "drive" {} \; | xargs cat

Length of output: 88271

---

Script:

#!/bin/bash
# Check default metrics configuration
echo "Checking default metrics configuration..."
fd -e js -e json -e yaml config --exec grep -l "metrics" {} \; | xargs cat

# Check if there are any other references to drive metrics
echo "Checking other drive metrics references..."
rg "drive.*metrics" --type js

Length of output: 129252

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.