Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use github-hosted arm runner for release workflow #2452

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Feb 6, 2025

Issue being fixed or feature implemented

Using amd architecture with QEMU emulation to build arm images is super slow. Github introduced free arm runners recently

What was done?

  • Use github-hosted arm runners for release workflow

How Has This Been Tested?

Building Drive from this branch https://github.com/dashpay/platform/actions/runs/13172956921

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated the automated pipeline for building and publishing Docker images.
    • Enhanced support for ARM-based environments for improved compatibility.
    • Streamlined the process by removing redundant automation steps to boost efficiency.

Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Walkthrough

This pull request updates the GitHub Actions workflow used for releasing Docker images. The changes include modifying the job matrix to target an ARM runner by switching from ubuntu-24.04 to ubuntu-24.04-arm and removing the conditional QEMU setup step that was used for cross-platform builds. The build and publish steps are maintained, ensuring that the release process remains largely unchanged aside from these workflow simplifications.

Changes

File(s) Change Summary
.github/.../release-docker-image.yml Updated ARM runner from ubuntu-24.04 to ubuntu-24.04-arm and removed the conditional QEMU setup step

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions
    participant Matrix as Job Matrix
    participant ARM as ARM Runner (ubuntu-24.04-arm)
    participant Build as Build Step
    participant Publish as Publish Step

    GH->>Matrix: Trigger workflow run
    Matrix->>ARM: Allocate job (ARM build)
    ARM->>Build: Execute build process
    ARM->>Publish: Execute publish process
Loading

Possibly related PRs

Suggested reviewers

  • QuantumExplorer
  • lklimek

Poem

In the realm of code, I hop with cheer,
Adjusting runners so build steps appear.
No QEMU to slow our boundless pace,
With ARM leaping in its rightful place.
A joyful dance in CI twilight,
🐰 Hop along to a future bright!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b1c252 and cdba792.

📒 Files selected for processing (1)
  • .github/workflows/release-docker-image.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release-docker-image.yml

42-42: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build JS packages / Build JS
🔇 Additional comments (2)
.github/workflows/release-docker-image.yml (2)

32-39: Workflow Consistency & QEMU Setup Removal Confirmation
The removal of the conditional QEMU setup step is consistent with switching to a native ARM runner. This simplification should improve build performance as intended. Please ensure that all cross-compilation or emulation-related dependencies have been fully addressed by the native ARM environment.

Also applies to: 44-52


40-43: ⚠️ Potential issue

Runner Matrix Update – Verify ARM Runner Label
The new matrix entry on line 42 specifies runner: ubuntu-24.04-arm for the linux/arm64 platform, which aligns with the objective to use a native ARM runner (eliminating QEMU emulation). However, static analysis (actionlint 1.7.4) flags this label as unknown. Please verify that ubuntu-24.04-arm is an officially supported GitHub-hosted runner label. If this is intended as a custom label for a self-hosted runner, consider updating the actionlint configuration to include it; otherwise, update the label to one of the recognized options (e.g., using an appropriate ARM-specific label provided by GitHub).

🧰 Tools
🪛 actionlint (1.7.4)

42-42: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shumkov shumkov added this to the v2.0.0 milestone Feb 6, 2025
@shumkov shumkov merged commit 9daa195 into v2.0-dev Feb 11, 2025
37 checks passed
@shumkov shumkov deleted the ci/use-arm-runner-for-release branch February 11, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants