refactor(blocksync): migrate peer-manager on generic store #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync-peer-manager' into refactor/td-162-implement-statesync-peer-manager
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
shotonoff
force-pushed
the
refactor/blocksync-peer-manager
branch
from
fd6d5d3
to
da0647c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
lklimek
reviewed
Aug 18, 2023
…refactor/blocksync-peer-manager
lklimek
previously approved these changes
Aug 21, 2023
Base automatically changed from
refactor/td-162-implement-statesync-peer-manager
to
v0.13-dev
August 21, 2023 10:00
lklimek
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To reduce code duplication, the blocksync peer-manager needs to be migrated on store.Store[types.NodeID, PeerData] component
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only