Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ak.str as dak.str #339

Merged
merged 14 commits into from
Sep 14, 2023

Conversation

douglasdavis
Copy link
Collaborator

Following scikit-hep/awkward#2616 we can add dask_awkward.str

@douglasdavis douglasdavis force-pushed the support-ak-dot-str branch 2 times, most recently from 3eec3ab to e275b99 Compare September 6, 2023 14:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #339 (bd1197a) into main (c08b303) will increase coverage by 0.39%.
The diff coverage is 96.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   94.56%   94.96%   +0.39%     
==========================================
  Files          22       23       +1     
  Lines        2613     2780     +167     
==========================================
+ Hits         2471     2640     +169     
+ Misses        142      140       -2     
Files Changed Coverage Δ
src/dask_awkward/lib/core.py 92.68% <60.00%> (+0.71%) ⬆️
src/dask_awkward/lib/str.py 97.51% <97.51%> (ø)
src/dask_awkward/__init__.py 100.00% <100.00%> (ø)
src/dask_awkward/lib/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglasdavis douglasdavis force-pushed the support-ak-dot-str branch 2 times, most recently from b63e2c8 to 39f5dd8 Compare September 14, 2023 16:17
@douglasdavis douglasdavis marked this pull request as ready for review September 14, 2023 16:24
@douglasdavis douglasdavis changed the title draft: feat: support ak.str as dak.str feat: support ak.str as dak.str Sep 14, 2023
@douglasdavis douglasdavis enabled auto-merge (squash) September 14, 2023 18:30
@douglasdavis douglasdavis merged commit 3d7d2c5 into dask-contrib:main Sep 14, 2023
18 checks passed
@douglasdavis douglasdavis deleted the support-ak-dot-str branch September 14, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants