transition_memory_released and get_nbytes() optimizations
#4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one case where this variable is used it is a `dict`. So go ahead and annotate it that way. Should speed up usage of this variable when cythonized.
To avoid calling this method repeatedly in a few cases, assign the result to a variable and reuse it.
jakirkham
force-pushed
the
typ_ts_nbytes
branch
from
8b5b3de to
6103304
Compare
jakirkham
changed the title
ts.get_nbytes() to a variabletransition_memory_released and get_nbytes() optimizations
|
Planning on merging end of day Monday if no comments |
|
Looks good to me |
quasiben
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize a few things in
transition_memory_released.To avoid calling
TaskState.get_nbytes()repeatedly in a few cases, assign the result to a variable and reuse it.black distributed/flake8 distributed