Log messages for CommClosedError now includes information about remote address #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might close #5202 ? |
Maybe there are other places where we raise a CommClosedError? |
fjetter
force-pushed
the
enrich_log_commclosed_handle_stream
branch
from
c3426e5 to
9b51554
Compare
fjetter
changed the title
fjetter
changed the title
|
I went through all logs and raises and adjusted the messages accordingly. Together with #5203 all exceptions should now be much more informative |
|
Checking in. What is the status here? |
|
@crusaderky do you have time to review? This seems like it would be easy for you. |
crusaderky
reviewed
Aug 19, 2021
|
Asides trivial cosmetic issues everything LGTM |
Co-authored-by: crusaderky <crusaderky@gmail.com>
jrbourbeau
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs like these may pop up on scheduler side. Depending on your logging system it can be quite helpful to know who the other side is.
Closes #5202