Fix concurrency assumptions for test_worker_reconnects_mid_compute #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
requested changes
Dec 22, 2021
crusaderky
reviewed
Jan 10, 2022
Co-authored-by: crusaderky <crusaderky@gmail.com>
crusaderky
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both tests are relying on the assumption that there are two workers with one thread each. However, I never realized that the default configuration for gen_cluster is one worker with one thread and another worker with two thread. That messes with the test assumptions.
The tests are reliably failing on windows, according to the test report. I'm not entirely sure if this is the only flaw with the tests but it is a start
Might fix #5621