-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around flakyness in spill hysteresis #5850
Conversation
ca3e0b3
to
8f2ffa2
Compare
This reverts commit ef0e44b.
Stress test (120 runs) is all green: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to start a discussion about how we write tests for memory related things.
- This particular test is very complex and slow
- We're allocating a lot of memory. I would prefer keeping unit tests low on resources even if 1GB should be not a problem
- Relying on OS RSS reporting appears to be fragile. We're still xfailing on OSX.
I believe this is a situation where I would prefer mocking. The one measurement we rely on that is critical and the culprit for all the flakiness is proc.memory_info().rss
. This is a very stable API and we could easily mock this by encapsulating it in a function. In the end, what we want to test is our spill logic assuming psutil/OS does properly report RSS. We do not want to test how the OS manages memory, this is outside of our control.
Superseded by #5870 |
test_spill_hysteresis
flaky on ubuntu #5848