Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log_event threadsafe #5946

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Make log_event threadsafe #5946

merged 1 commit into from
Mar 16, 2022

Conversation

gjoseph92
Copy link
Collaborator

@gjoseph92 gjoseph92 self-assigned this Mar 15, 2022
@github-actions
Copy link
Contributor

Unit Test Results

       12 files  ±0         12 suites  ±0   5h 45m 28s ⏱️ - 6m 49s
  2 653 tests ±0    2 569 ✔️  - 1    80 💤 ±0  4 ❌ +1 
13 021 runs  ±0  12 380 ✔️ ±0  636 💤  - 1  5 ❌ +1 

For more details on these failures, see this check.

Results for commit f3d442a. ± Comparison against base commit 7a69b5e.

@gjoseph92 gjoseph92 requested review from crusaderky and fjetter March 15, 2022 22:25
@fjetter
Copy link
Member

fjetter commented Mar 16, 2022

It appears this is the only place where BatchedSend.send is used in a different thread.

@fjetter fjetter merged commit 3492ef1 into dask:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter fjetter approved these changes

@crusaderky crusaderky Awaiting requested review from crusaderky

Assignees

@gjoseph92 gjoseph92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker.log_event is not threadsafe / BatchedSend.send not threadsafe
2 participants
@gjoseph92 @fjetter