Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributed.metrics.monotonic #6181

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

crusaderky
Copy link
Collaborator

To be used in #6174

@crusaderky crusaderky mentioned this pull request Apr 23, 2022
3 tasks
@github-actions
Copy link
Contributor

Unit Test Results

       16 files  ±0         16 suites  ±0   7h 45m 45s ⏱️ + 16m 59s
  2 728 tests +1    2 645 ✔️ +1       80 💤  - 1  3 +1 
21 709 runs  +8  20 670 ✔️ +7  1 036 💤 ±0  3 +1 

For more details on these failures, see this check.

Results for commit fd31724. ± Comparison against base commit 370f456.

@mrocklin
Copy link
Member

I think that maybe distributed.metrics.time would work on in that case? Maybe we can just use that.

@crusaderky
Copy link
Collaborator Author

I think that maybe distributed.metrics.time would work on in that case? Maybe we can just use that.

I'm worried about bad OS use cases. Specifically, the NTP sync could, for whatever reason, suddenly bring back the wall clock several seconds, instead of a few tens of milliseconds like it happens on a healthy box. If that ever happens, the spill system will send the worker in a complete apnoea until it's completely done, thus triggering timeouts.

An even more delicate use case is #6189. There, if the clock is sent back a few seconds during a particularly painful spill it may give enough time for the worker to rise in memory usage from 70% to 95% without having a chance to pause.

crusaderky added a commit to crusaderky/distributed that referenced this pull request Apr 25, 2022
crusaderky added a commit to crusaderky/distributed that referenced this pull request Apr 25, 2022
@crusaderky crusaderky merged commit b7fc7be into dask:main Apr 25, 2022
@crusaderky crusaderky deleted the metrics.monotonic branch April 25, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants