@gen_cluster to write to /tmp #6237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Apr 28, 2022
| loop, | ||
| with tempfile.TemporaryDirectory() as tmpdir: | ||
| config2 = merge({"temporary-directory": tmpdir}, config) | ||
| with dask.config.set(config2): |
There was a problem hiding this comment.
Everything beyond this line is just an extra indentation
|
+1 in principle |
Unit Test Results 16 files ±0 16 suites ±0 7h 30m 48s ⏱️ + 7m 25s For more details on these failures, see this check. Results for commit 96201b4. ± Comparison against base commit 70e1fca. ♻️ This comment has been updated with latest results. |
|
The move to /tmp seems inconsequential to #6233. I think it's still good to have in regardless. |
crusaderky
force-pushed
the
tmp_worker_space
branch
from
3571e73 to
c43fc03
Compare
|
Ready for final review |
|
All failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't leave cruft around the working directory. Prevent a wealth of problems for developers with their home directory on a network filesystem.
Closes #6233.