-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor find_missing and refresh_who_has #6348
Conversation
8eb8eea
to
56c796c
Compare
56c796c
to
cbccc86
Compare
As the git tree has become messy, until #6342 is merged the diff of this PR is visible at crusaderky#3 |
45dc795
to
2f96f32
Compare
@fjetter this has been updated to reflect the new update_who_has. |
Ironically, with this PR some changes that we just introduced in the update_who_has PR can now be reverted: df488f0 |
c0b2bd4
to
50f83d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
Just for reference, there is a discussion going on that the entire find-missing mechanism can likely be removed entirely. I'm fine with this refactoring that moves us closer to a more robust architecture see #6445
if not isinstance(stim, FindMissingEvent): | ||
self.stimulus_log.append(stim.to_loggable(handled=time())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you're logging this because it is flooding the log otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Plus, it's really not interesting to see in the log even when relevant. Note that the response from the scheduler is logged.
ensure_communicating
transitions to new WorkerState event mechanism #5896Additional changes to #6342 are visible at crusaderky#3
Refactor Worker->Scheduler queries to fetch who_has, from RPC to bulk comms. This removes one of the two async commands in
gather_dep
(the other being the actual data request) and is propaedeutic to its refactoring.Fix minor bug where: