Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit tests mocking gather_dep #6385

Merged
merged 2 commits into from
May 20, 2022
Merged

Revisit tests mocking gather_dep #6385

merged 2 commits into from
May 20, 2022

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented May 20, 2022 •
edited
Loading

Partially closes #5896

@crusaderky crusaderky requested review from fjetter and gjoseph92 May 20, 2022 00:16
@crusaderky crusaderky self-assigned this May 20, 2022
@crusaderky crusaderky marked this pull request as ready for review May 20, 2022 00:17
crusaderky added a commit to crusaderky/distributed that referenced this pull request May 20, 2022
@crusaderky
Revert (moved to dask#6385)
7021526
crusaderky added a commit to crusaderky/distributed that referenced this pull request May 20, 2022
@crusaderky
Revisit tests mocking gather_dep (dask#6385)
4488144
@crusaderky crusaderky mentioned this pull request May 20, 2022
Merged
@github-actions
Copy link
Contributor

Unit Test Results

       15 files  ±    0         15 suites  ±0   7h 34m 37s ⏱️ + 29m 48s
  2 804 tests ±    0    2 723 ✔️ ±    0    79 💤 ±  0  2 ❌ ±0 
20 794 runs   - 400  19 871 ✔️  - 338  921 💤  - 62  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit e62b121. ± Comparison against base commit 33fc50c.

@crusaderky crusaderky merged commit a293d65 into dask:main May 20, 2022
@crusaderky crusaderky deleted the WSMR/mock_gather_dep branch May 20, 2022 13:50
@crusaderky crusaderky mentioned this pull request May 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter fjetter approved these changes

@gjoseph92 gjoseph92 Awaiting requested review from gjoseph92

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ensure_communicating transitions to new WorkerState event mechanism
2 participants
@crusaderky @fjetter