A key is forgotten while acquire-replicas is running #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
forget_acquire_replicas
branch
from
18eca1d to
582623c
Compare
crusaderky
force-pushed
the
forget_acquire_replicas
branch
from
582623c to
3c9c528
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 10h 20m 17s ⏱️ - 3m 21s For more details on these failures and errors, see this check. Results for commit 3c9c528. ± Comparison against base commit a8eb3b2. |
hendrikmakait
approved these changes
Jun 29, 2022
| @@ -531,7 +531,12 @@ async def test_fetch_to_missing(c, s, a, b): | |||
| 6. the scheduler responds {"x": []}, because w1 in the meantime has lost the key. | |||
| 7. x is transitioned fetch -> missing | |||
| """ | |||
| x = await c.scatter({"x": 1}, workers=[b.address]) | |||
| # Note: submit and scatter are different. If you lose all workers holding the | |||
There was a problem hiding this comment.
Thanks for the explanation of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6479