Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

pausing a dat doesn't stop uploading #293

Closed
yoshuawuyts opened this issue Mar 8, 2017 · 4 comments
Closed

pausing a dat doesn't stop uploading #293

yoshuawuyts opened this issue Mar 8, 2017 · 4 comments

Comments

@yoshuawuyts
Copy link
Contributor

Verified this on #291 that hitting pause on a dat doesn't stop it from being uploaded over MDNS - might also be the case on TCP, UDP. Def worth looking into.

@juliangruber
Copy link
Collaborator

@joehand hey, is this something we can solve in dat-node?

Otherwise, we could also just .kill() the dat-worker child processes for a clean pause, however that is not as efficient

@joehand
Copy link
Contributor

joehand commented Mar 8, 2017

@joehand hey, is this something we can solve in dat-node?

Yes! I added the pause/resume (which does the same as join/leave). But I think there may have a bug in the join/leave.

I will release a new dat-node version today that we can test.

@joehand
Copy link
Contributor

joehand commented Mar 9, 2017

This appears fixed with the upgrade to dat-node 1.4! (though not 100% sure I verified correctly)

@juliangruber
Copy link
Collaborator

@joehand thank you, that fixed the MDNS case for sure! Since the others weren't reported as particular problems (yet), closing for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants