This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Add pause/resume. Closes #266. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
changed the title
|
This is ready for review now! @Kriesse can you look over the hex icons and make sure everything is as you intended? |
juliangruber
commented
Mar 4, 2017
| @@ -22,6 +22,7 @@ module.exports = createModel | |||
|
|
|||
| function createModel () { | |||
| let manager = null | |||
| let dbPaused = null | |||
There was a problem hiding this comment.
seems easier to use a separate db for this, than integrating into multidrive and multidat
juliangruber
commented
Mar 4, 2017
| function createManager (multidat, onupdate) { | ||
| assert.ok(multidat, 'models/repos: multidat should exist') | ||
| assert.ok(onupdate, 'models/repos: onupdate should exist') | ||
| function togglePause (state, data, send, done) { |
There was a problem hiding this comment.
needed to change indentation, so this looks messy. however i didn't change anything besides adding the togglePause method and reading from dbPaused
yoshuawuyts
approved these changes
Mar 8, 2017
There was a problem hiding this comment.
LGTM - tested and noticed that uploading doesn't always stop - issue here #293, don't think it should block this merge tho
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kriesse can you take over with some styling? I needed to turn the status hex icons into buttons, but this is how it looks with my changes: