Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

fix: overlay on menu open. #600

Merged
merged 4 commits into from
Nov 30, 2018
Merged

fix: overlay on menu open. #600

merged 4 commits into from
Nov 30, 2018

Conversation

AtuyL
Copy link
Collaborator

@AtuyL AtuyL commented Nov 22, 2018

This PR for to-re-working the overlay on menu-open.

@martinheidegger
Copy link
Collaborator

Looks weird on my computer:

screen shot 2018-11-22 at 15 28 28

@martinheidegger
Copy link
Collaborator

Even weirder when window is to small and dev-tools open + scroll

screen shot 2018-11-22 at 15 30 14

(could it be that the shadow layer is above the overlay?)

Copy link
Collaborator

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the layout issues first.

AtuyL added a commit that referenced this pull request Nov 22, 2018
@AtuyL
Copy link
Collaborator Author

AtuyL commented Nov 22, 2018

#600 (comment)
it is fix by other pr.
#593

@AtuyL AtuyL force-pushed the fix/overlay-on-menu-open branch from b874afd to f80856c Compare November 23, 2018 01:10
AtuyL added a commit that referenced this pull request Nov 23, 2018
@AtuyL AtuyL force-pushed the fix/overlay-on-menu-open branch from f80856c to 0c85c3c Compare November 23, 2018 01:11
AtuyL added a commit that referenced this pull request Nov 23, 2018
@AtuyL
Copy link
Collaborator Author

AtuyL commented Nov 23, 2018

@martinheidegger san
fixed :)
screenshot 2018-11-23 11 02 15

@AtuyL AtuyL force-pushed the fix/overlay-on-menu-open branch from 0c85c3c to 32d3814 Compare November 29, 2018 01:29
AtuyL added a commit that referenced this pull request Nov 29, 2018
AtuyL added a commit that referenced this pull request Nov 29, 2018
@AtuyL AtuyL dismissed martinheidegger’s stale review November 29, 2018 01:29

please re-review.

@AtuyL AtuyL force-pushed the fix/overlay-on-menu-open branch from 32d3814 to 5d05d27 Compare November 30, 2018 05:20
Copy link
Collaborator

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making it work with the z-index. I know its a bit of a hacky solution. Lets make it cleaner in future version.

@AtuyL AtuyL merged commit 73456a4 into master Nov 30, 2018
@AtuyL AtuyL deleted the fix/overlay-on-menu-open branch November 30, 2018 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants