This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
Style Account and Login UI #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2017
yoshuawuyts
reviewed
Jan 14, 2017
| @@ -12,44 +12,72 @@ const login = (state, prev, send) => { | |||
|
|
|||
| var prefix = css` | |||
There was a problem hiding this comment.
Ah yeah, so declaring this inline is causing the duplicate CSS issue. Each time this function is called, a new line of CSS is appended to head, which causes the performance problems.
When using bankai we use the extract-css transform which takes this declaration and turns it into a static string which means it's no problem. If you move this outside the scope e.g. to line 4 it should all be good (:
| <input type="password" placeholder="Password" name="password" /> | ||
| <input type="submit" value="Register" /> | ||
| </form> | ||
| var prefix = css` |
There was a problem hiding this comment.
move this declaration to line 4 also and you should be good (:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements modal styles that we already have in Dat Desktop.
To Do: Re-use those styles instead of duplicating them in register and login. Probably by creating a modal element.