Resolve compile, lint and fmt warnings #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustdoc doesn't support generating documentation for macros. Make the doc comments normal comments to resolve the warnings.
Update `lazy_static` depedency to the latest version to resolve deprecation warnings for `std::sync::ONCE_INIT`.
Update `combine` dependency to the latest version to resolve clippy warning about `ref` on an entire `let` pattern. The upgrade introduced deprecation warnings for `combine`'s `try` method which has been renamed due to its collision with the `try` keyword which is reserved in Rust 2018. Resolve this as well.
Resolves `clippy::char_lit_as_u8`
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 83.35% 83.30% -0.05%
==========================================
Files 5 4 -1
Lines 1514 1426 -88
==========================================
- Hits 1262 1188 -74
+ Misses 252 238 -14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a housekeeping PR:
I resolved all warnings which pop up when the project is opened using a current toolchain. Nothing really big popped up. The only thing that may be of interest is that I updated two dependencies (
lazy_staticandcombine), these were in-range updates though. You can a detailed list of the changes I made by going over the commits, I chunked quite granular carefully.The only big thing pending to get the project back to current is upgrading it to 2018 edition, which will require a couple of changes because
asyncis now a reserved keyword. That's why I decided to not do it for this PR.Happy to address any concerns. 🙂