Adding support for NumPy v1.18.0 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X] Wrote test for feature
[X] Added changes to CHANGELOG.md
[X] Bumped version number (delete if unneeded)
Changes proposed:
Due to the changes between NumPy v1.17.5 -> 1.18.0 (especially noted in this PR: numpy/numpy#14745), some updating is required to our Row's getattr function.
Small tl;dr on the NumPy PR: conversion to a NumPy array via the
np.array(..)function would catch any exceptions for the required np.array fields. At v1.18.0, it's now been changed such that it only catches exceptions for AttributeErrors - hence this change.I'd suggest that the new error message and Exception type is actually better than the one we'd get previously so I think this is the right move to make regardless.
Closes #425.