-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details to expectations for scalars #308
Merged
Merged
Changes from 3 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
751a131
note what may raise
MarcoGorelli 7cb90ea
Merge remote-tracking branch 'upstream/main' into expand-on-scalars
MarcoGorelli fc65648
list required methods
MarcoGorelli 7c24afd
add scalar class
MarcoGorelli 2714c13
reword
MarcoGorelli 99b91a5
fixup
MarcoGorelli a867f00
fixup
MarcoGorelli 9e13924
Merge remote-tracking branch 'upstream/main' into expand-on-scalars
MarcoGorelli f197672
fixup
MarcoGorelli a417b1c
Merge remote-tracking branch 'upstream/main' into expand-on-scalars
MarcoGorelli 409d8f3
replace Scalar|NullType with Scalar
MarcoGorelli 0db9871
type null as Scalar
MarcoGorelli 6520ac4
add example of working with scalars
MarcoGorelli 46bc08c
use AnyScalar;
MarcoGorelli b879f31
add Scalar.dtype and Scalar.persist
MarcoGorelli 456c152
Merge remote-tracking branch 'upstream/main' into expand-on-scalars
MarcoGorelli b8011c7
update shift arg
MarcoGorelli 97d8f9a
use BoolScalar
MarcoGorelli 3b7bcb6
use float scalar in some parts
MarcoGorelli d598a8d
use float scalar in some parts
MarcoGorelli a12585b
string scalar for rename
MarcoGorelli 35cd4ed
intscalar for shift
MarcoGorelli fade164
numeric scalar for correction
MarcoGorelli 29ceed2
simplify
MarcoGorelli bee402f
update python builtin types desc
MarcoGorelli d1f4daf
Merge remote-tracking branch 'upstream/main' into expand-on-scalars
MarcoGorelli 15090ac
fixup
MarcoGorelli 24d2ad8
enable extra ruff rule, note AnyScalar
MarcoGorelli 8360d96
remove some unnecessary nitpick ignores
MarcoGorelli f69679a
return Self from Scalar.persist, add column.persist
MarcoGorelli 216b5e6
fixup
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
punt on these