Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunking for uniform grids #30

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

chrishavlin
Copy link
Collaborator

This implements a chunking mechanism for 3D data on uniform grids for load_grid. Works for both interpolated and non-interpolated data. The chunk sizes may be set independently of any xarray chunking, and dask arrays do work in this framework (but multiple dask chunks may be contained in a yt grid depending on the provided chunksizes argument.

relevant to: #28

@chrishavlin chrishavlin added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 6, 2023
@chrishavlin chrishavlin added this to the v0.1.1 and announcement milestone Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 97.87% // Head: 98.21% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (80d50b1) compared to base (a60b504).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   97.87%   98.21%   +0.34%     
==========================================
  Files          14       15       +1     
  Lines         893     1065     +172     
==========================================
+ Hits          874     1046     +172     
  Misses         19       19              
Impacted Files Coverage Δ
tests/test_chunking.py 100.00% <100.00%> (ø)
yt_xarray/accessor/_xr_to_yt.py 96.59% <100.00%> (+0.01%) ⬆️
yt_xarray/accessor/accessor.py 97.84% <100.00%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrishavlin chrishavlin merged commit caa8cb4 into data-exp-lab:main Feb 6, 2023
@chrishavlin chrishavlin deleted the chunks branch November 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant