chore: disable proxy conditionally mode

data-fair · Dec 12, 2024 · e18e53a · e18e53a
1 parent c3c3a00
commit e18e53a
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 24 deletions.
diff --git a/config/custom-environment-variables.js b/config/custom-environment-variables.js
@@ -0,0 +1,9 @@
+/**
+ * @param {string} key
+ */
+const jsonEnv = (key) => ({ __name: key, __format: 'json' })
+
+module.exports = {
+  port: 'PORT',
+  allowProxy: jsonEnv('ALLOW_PROXY')
+}
diff --git a/config/default.js b/config/default.js
@@ -1,3 +1,4 @@
 module.exports = {
-  port: 5600
+  port: 5600,
+  allowProxy: true
 }
diff --git a/public/index.html b/public/index.html
@@ -35,6 +35,7 @@
 <body class="openapi-viewer">
   <div id="app"></div>
   <script>
+    // [DYNAMIC]
     window.iFrameResizer = {
       heightCalculationMethod: 'taggedElement'
     }

diff --git a/public/src/App.vue b/public/src/App.vue
@@ -12,7 +12,7 @@
         <md-button @click.native="refresh">
           <md-icon>autorenew</md-icon>
         </md-button>
-        <md-checkbox v-model="useProxy" title="Allows to bypass CORS restrictions">Use proxy</md-checkbox>
+        <md-checkbox v-if="allowProxy" v-model="useProxy" title="Allows to bypass CORS restrictions">Use proxy</md-checkbox>
       </md-layout>
     </md-layout>
   </md-toolbar>
@@ -65,15 +65,19 @@ export default {
   components: {
     OpenApi
   },
-  data: () => ({
-    api: null,
-    error: null,
-    useProxy: proxyParam === 'true' || false,
-    url: urlParam || 'https://koumoul.com/s/geocoder/api/v1/api-docs.json',
-    headers: (getParameterByName('headers') && JSON.parse(decodeURIComponent(getParameterByName('headers')))) || {},
-    queryParams : (getParameterByName('query-params') && JSON.parse(decodeURIComponent(getParameterByName('query-params')))) || {},
-    showToolbar: !(getParameterByName('hide-toolbar') === 'true')
-  }),
+  data() {
+    const allowProxy = typeof window !== 'undefined' && window.CONFIG && window.CONFIG.allowProxy
+    return {
+      api: null,
+      error: null,
+      allowProxy,
+      useProxy: allowProxy ? (proxyParam === 'true' || false) : false,
+      url: urlParam || 'https://koumoul.com/s/geocoder/api/v1/api-docs.json',
+      headers: (getParameterByName('headers') && JSON.parse(decodeURIComponent(getParameterByName('headers')))) || {},
+      queryParams: (getParameterByName('query-params') && JSON.parse(decodeURIComponent(getParameterByName('query-params')))) || {},
+      showToolbar: !(getParameterByName('hide-toolbar') === 'true')
+    }
+  },
   mounted() {
     this.refresh()
   },

diff --git a/server/app.js b/server/app.js
@@ -2,23 +2,25 @@ const config = require('config')
 const express = require('express')
 const path = require('node:path')
 const axios = require('axios').default
+const fs = require('node:fs')
 
 let app = module.exports = express()
 
-// Business routers
-app.get('/proxy', (req, res) => {
-  if (!req.query.url || typeof req.query.url !== 'string') {
-    return res.status(400).send('url query parameter is required')
-  }
+if (config.allowProxy === true) {
+  app.get('/proxy', (req, res) => {
+    if (!req.query.url || typeof req.query.url !== 'string') {
+      return res.status(400).send('url query parameter is required')
+    }
 
-  axios.get(req.query.url, {
-    responseType: 'stream'
-  }).then((response) => {
-    response.data.pipe(res)
-  }).catch((err) => {
-    res.status(500).send(err.message)
+    axios.get(req.query.url, {
+      responseType: 'stream'
+    }).then((response) => {
+      response.data.pipe(res)
+    }).catch((err) => {
+      res.status(500).send(err.message)
+    })
   })
-})
+}
 
 // Static routing
 const oneWeek = 7 * 24 * 60 * 60
@@ -31,9 +33,14 @@ const staticOptions = {
 app.use('/assets', express.static(path.join(__dirname, '../public/assets'), staticOptions))
 app.use('/bundles', express.static(path.join(__dirname, '../public/bundles'), staticOptions))
 
+const htmlPath = path.join(__dirname, '../public/index.html')
+const htmlContent = fs.readFileSync(htmlPath, 'utf8')
+    .replaceAll('// [DYNAMIC]', 'window.CONFIG = ' + JSON.stringify({ allowProxy: config.allowProxy }))
+
 app.use('/*', (req, res) => {
   res.setHeader('Cache-Control', 'public, max-age=0')
-  res.sendFile(path.join(__dirname, '../public/index.html'))
+  res.setHeader('Content-Type', 'text/html')
+  res.send(htmlContent)
 })
 
 // Error handling to complement express default error handling. TODO do something useful of errors.