Feat hebrew transcription #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atalyaalon
force-pushed
the
feat-hebrew-transcription
branch
from
e5e620d
to
d43a342
Compare
This was
linked to
issues
Jun 22, 2023
ziv17
reviewed
Jun 23, 2023
There was a problem hiding this comment.
Hi @shaysw, @atalyaalon
Well done.
A few points:
- Is the English transcription text reasonable?
- I see we pass segment and junction names through Babel. Do we plan to translate such names with Babel?
- The transcription code is very similar between widgets, and has complicated logic. It may be costly to maintain. I do not have a better idea though. Maybe there are better tools to generate such text? Or maybe we can use similarities between widgets to reduce duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.