Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2478 add streets table from datagov #2668

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Jun 7, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 6.41026% with 73 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (400af13) to head (24ea9d1).
Report is 52 commits behind head on dev.

Files Patch % Lines
anyway/parsers/streets.py 0.00% 62 Missing ⚠️
anyway/parsers/infographics_data_cache_updater.py 25.00% 6 Missing ⚠️
main.py 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2668      +/-   ##
==========================================
- Coverage   53.22%   53.20%   -0.02%     
==========================================
  Files         119      120       +1     
  Lines        9924    10072     +148     
==========================================
+ Hits         5282     5359      +77     
- Misses       4642     4713      +71     
Flag Coverage Δ
unittests 53.20% <6.41%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 marked this pull request as ready for review June 7, 2024 08:51
@ziv17 ziv17 force-pushed the 2478-add-streets-table-from-datagov branch from 57704cf to 24ea9d1 Compare June 10, 2024 03:42
@ziv17 ziv17 requested review from atalyaalon and tkalir June 10, 2024 03:58
@ziv17 ziv17 merged commit dc7b6c2 into data-for-change:dev Jun 14, 2024
3 checks passed
RESOURCE_NAME = "רשימת רחובות בישראל - מתעדכן"
BASE_GET_DATA_GOV = "https://data.gov.il/dataset/321"
RESOURCE_DOWNLOAD_TEMPLATE = (
"https://data.gov.il/api/3/action/datastore_search?resource_id={id}&limit=100000"
Copy link
Collaborator

@atalyaalon atalyaalon Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziv17 this limit is too small (and is it necessary to add a limit? perhaps we can just query all data?) since today there are 61455 records in the table, and I assume we can reach a time, at some point where 100000 is not enough.
If we must add a limit, I suggest adding one or two zeros to be on the safe side :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default limit is 32k, so we must supply a limit. I did not find a way to work with pagination. I will set the limit to 1M.

@atalyaalon
Copy link
Collaborator

@ziv17 Great work! It's already merged to dev but not to master yet: I'm waiting for the CBS final answer that our method is correct for the merge.
In addition, before merging to production I suggest you also remove the code that updates the streets table from CBS data (this code is in cbs anyway/parsers/cbs/executor.py) - I opened an issue for this: #2674

However, let's wait for the final answer of the CBS and then implement this last part

@ziv17 ziv17 deleted the 2478-add-streets-table-from-datagov branch August 11, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants