-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2478 add streets table from datagov #2668
2478 add streets table from datagov #2668
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #2668 +/- ##
==========================================
- Coverage 53.22% 53.20% -0.02%
==========================================
Files 119 120 +1
Lines 9924 10072 +148
==========================================
+ Hits 5282 5359 +77
- Misses 4642 4713 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
57704cf
to
24ea9d1
Compare
RESOURCE_NAME = "רשימת רחובות בישראל - מתעדכן" | ||
BASE_GET_DATA_GOV = "https://data.gov.il/dataset/321" | ||
RESOURCE_DOWNLOAD_TEMPLATE = ( | ||
"https://data.gov.il/api/3/action/datastore_search?resource_id={id}&limit=100000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ziv17 this limit is too small (and is it necessary to add a limit? perhaps we can just query all data?) since today there are 61455 records in the table, and I assume we can reach a time, at some point where 100000 is not enough.
If we must add a limit, I suggest adding one or two zeros to be on the safe side :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default limit is 32k, so we must supply a limit. I did not find a way to work with pagination. I will set the limit to 1M.
@ziv17 Great work! It's already merged to dev but not to master yet: I'm waiting for the CBS final answer that our method is correct for the merge. However, let's wait for the final answer of the CBS and then implement this last part |
No description provided.