Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TermsAndConditionsPageFixes #266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

TermsAndConditionsPageFixes #266

wants to merge 2 commits into from

Conversation

Rohanfizz
Copy link
Contributor

Ticket Description

Fixes tasks 1,3,5 of issue #224

Ticket Description

Fixes tasks 1,3,5 of issue #224

Description of Changes

Added Terms page to footer, added spacing between table of contents headings, fixed the scroll behaviour of table of contents and fixed some css to match figma.

Before and After for UI Updates

Description of Changes

Added Terms page to footer, added spacing between table of contents headings, fixed the scroll behaviour of table of contents and fixed some css to match figma.

Before and After for UI Updates

Before:
PC before:
image
image

Mobile Before:
Screenshot (371)

After:
PC after:
image
image

Mobile after:
image

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

Copy link
Contributor

@jtorreggiani jtorreggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅, but let's hold off on merging until the language for the terms have been updated.

@reshamas
Copy link
Contributor

@YolineB
It looks like a T&C page is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants