Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 212 Dark mode logo for About Us Page #372

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Issue 212 Dark mode logo for About Us Page #372

merged 5 commits into from
Feb 17, 2023

Conversation

YolineB
Copy link
Contributor

@YolineB YolineB commented Feb 11, 2023

PR Overview

Updates logo for Data Umbrella in the About Us section for dark mode

Type of contribution

  • Code
  • Documentation

Reference: Issue or Pull Request (PR)

Description of Changes

Added image to assets, updated AboutUsPage.jsx

Before and After for UI Updates

Before:
image

image

After:
image
image

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

@YolineB YolineB changed the title 212/logo dark mode about us page Issue 212 Dark mode logo for About Us Page Feb 11, 2023
@YolineB YolineB self-assigned this Feb 11, 2023
najwanan
najwanan approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@najwanan najwanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added logo for dark mode.

Looks good, approved

@YolineB YolineB merged commit 129ceb2 into main Feb 17, 2023
@YolineB YolineB deleted the 212/logo-dark-mode-about-us-page branch February 17, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najwanan najwanan najwanan approved these changes

Assignees

@YolineB YolineB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YolineB @najwanan