Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temp env loading fixed #426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

RajGM
Copy link

@RajGM RajGM commented Oct 13, 2023

PR Overview

Type of contribution

  • Code

Reference: Issue or Pull Request (PR)

  • [ /email/auth] Towards #xxx

Description of Changes

<-- Brief description of the changes you made, files you touched, etc -->
removes dependency from .env files and directly load from the code the URL endpoint for the localhost

Before and After for UI Updates

<-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->

Before:
error when sending request for magicLink API endpoint

After:
sends request to magic link API endpoint

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

@welcome
Copy link

welcome bot commented Oct 13, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The Data Umbrella community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant