Modest evaluation #189
Merged
Modest evaluation #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
approved these changes
Apr 1, 2022
| if total_rec == 0: | ||
| num_comparisons += len(dp1_recs) * len(dp2_recs) | ||
|
|
||
| found_matches.update(set(dp1_data[rec] for rec in dp1_recs).intersection(dp2_data[rec] for rec in dp2_recs)) |
There was a problem hiding this comment.
That looks faster than 3 nested for loops!
There was a problem hiding this comment.
slightly... For the 2Mx2M test file I've got, it reduces from tens of minutes to just a few seconds.
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 97.63% 97.61% -0.02%
==========================================
Files 18 18
Lines 634 630 -4
==========================================
- Hits 619 615 -4
Misses 15 15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into why the
asses_blocks_2partyfunction didn't scale well.As a result I simplified the loop and store less things in memory.
Also, the block keys can be quite large, e.g.:
"(3, 265, 403, 665, 927, 165, 41, 303, 565, 827, 965, 203, 465, 727, 865, 103, 365, 627, 503, 765)". That's a 97 character string, which can get problematic if you hold lots of those in memory.In case people don't need the Bloom filter indices, we can reduce these keys to some smaller hash.
I introduced an additional flag
"compress-block-key"in the"blocking-filter"section. If set toTrue, then blocklib will replace the large indices string with a 5 byte long blake2b hash.