Convert block key to string for P-sig #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 98.00% 98.01%
=======================================
Files 14 14
Lines 502 504 +2
=======================================
+ Hits 492 494 +2
Misses 10 10 |
wilko77
requested changes
Jun 11, 2020
blocklib/blocks_generator.py
Outdated
| @@ -89,6 +89,7 @@ def generate_blocks_psig(reversed_indices: Sequence[Dict], block_states: Sequenc | |||
| for reversed_index, state in zip(reversed_indices, block_states): | |||
| cbf = set() # type: Set[int] | |||
| for bf_set in reversed_index: | |||
| bf_set = eval(bf_set) | |||
There was a problem hiding this comment.
eval can lead to arbitrary code execution and should be avoided. Better use https://docs.python.org/3/library/ast.html#ast.literal_eval
blocklib/pprlpsig.py
Outdated
| @@ -97,7 +97,7 @@ def build_reversed_index(self, data: Sequence[Sequence], verbose: bool = False): | |||
| reversed_index = {} # type: Dict[Any, List[Any]] | |||
There was a problem hiding this comment.
Isn't the key now always a string?
There was a problem hiding this comment.
Yep, will update it to type: Dict[str, List[Any]]
wilko77
approved these changes
Jun 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I converted the block key type from set to string for P-sig blocking. Now the block key for both P-sig and lambda fold are consistent.
Close #74