Allow updates to OptionController while listening. fix #101

dataarts · Aug 18, 2016 · ca19030 · ca19030
1 parent f53cfa5
commit ca19030
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/dat/controllers/NumberControllerBox.js b/src/dat/controllers/NumberControllerBox.js
@@ -107,7 +107,7 @@ class NumberControllerBox extends NumberController {
   }
 
   updateDisplay() {
-    if (dom.isActive(this.__input)) return null; // prevent number from update if user is trying to manually update
+    if (dom.isActive(this.__input)) return this; // prevent number from updating if user is trying to manually update
     this.__input.value = this.__truncationSuspended ? this.getValue() : roundToDecimal(this.getValue(), this.__precision);
     return super.updateDisplay();
   }

diff --git a/src/dat/controllers/OptionController.js b/src/dat/controllers/OptionController.js
@@ -78,6 +78,7 @@ class OptionController extends Controller {
   }
 
   updateDisplay() {
+    if (dom.isActive(this.__select)) return this; // prevent number from updating if user is trying to manually update
     this.__select.value = this.getValue();
     return super.updateDisplay();
   }