Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update NumberControllerBox with .listen() #179

Open
samkohn opened this issue Feb 28, 2018 · 4 comments · May be fixed by #246
Open

Cannot update NumberControllerBox with .listen() #179

samkohn opened this issue Feb 28, 2018 · 4 comments · May be fixed by #246
Labels

Comments

@samkohn
Copy link

samkohn commented Feb 28, 2018

Symptom: when a NumberController has .listen(), I cannot manually update the number in the associated NumberControllerBox even though the slider works fine. A similar problem exists for color controllers, where I can change the color using the color picker but not by typing in a hex value.

History: This was previously reported in #100 (related to #101), and fixed in ca19030. The relevant line in NumberControllerBox.js was removed in dd5d0fc.

@zwcloud
Copy link

zwcloud commented Mar 23, 2018

I just ran into this. Adding that line back to dat.gui.js doesn't solve the issue.

@wenjiahuang
Copy link

This change fixed my issue. When do you plan to merge it to master?

@awelles awelles linked a pull request Jun 27, 2019 that will close this issue
@mjrlowe
Copy link

mjrlowe commented Sep 7, 2019

Sorry to pop out of nowhere but I encountered this bug recently and was wondering if it was going to get fixed sometime soon?

@aferriss
Copy link

aferriss commented May 27, 2020

Just chiming in that I'm also still encountering this issue.

One hacky solve for getting around this is just to pass your number as a string and then use parseInt / parseFloat when you need the number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants